Add ratio as a json data #1

New issue

Closed

opened 2023-05-21 19:09:20 +02:00 by caribaud · 1 comment

caribaud commented

2023-05-21 19:09:20 +02:00

Owner

Right now the pages height and width are hardcoded into the HTML reader frame :

<div id="reader-pages" class="animated" data-pages-width="9999" data-pages-height="9999" hidden>

The only goal is to compute the page ratio :

 function pageOriginalHeight() {
     return parseInt(READER_PAGES.dataset.pagesHeight)
 }
 function pageOriginalWidth() {
     return parseInt(READER_PAGES.dataset.pagesWidth)
 }
 function readerFrameRatio() {
     return READER_CONTENT_FRAME.clientWidth / READER_CONTENT_FRAME.clientHeight
 }
 function pageRatio() {
     return READER_PAGES.dataset.pagesWidth / READER_PAGES.dataset.pagesHeight
 }

This could be pre-computed by the generator and added into the json file, the SVG contains the info : svg tag, attribute width / height.

New structure could be : melpomene -> pages_ratio and melpomene -> zooms ?

Right now the pages height and width are hardcoded into the HTML reader frame : https://git.aribaud.net/caribaud/melpomene/src/commit/2e1bb56e422e7dd00c4f3a1d5acc043ea97cdff6/melpomene_reader.html#L6 The only goal is to compute the page ratio : https://git.aribaud.net/caribaud/melpomene/src/commit/2e1bb56e422e7dd00c4f3a1d5acc043ea97cdff6/melpomene.js#L113-L127 This could be pre-computed by the generator and added into the json file, the SVG contains the info : svg tag, attribute width / height. New structure could be : melpomene -> pages_ratio and melpomene -> zooms ?

caribaud commented

2023-05-26 21:12:29 +02:00

Author

Owner

Adding ratio is no longer necessary as it must be dynamically inferred when data is from HTML