mirror of
https://github.com/rstrouse/ESPSomfy-RTS.git
synced 2026-11-21 00:02:12 +01:00
fix: protocol 2 core review findings
From the review of #99: - A sync could stall when a client took a slot the moment another left: loop() used up the new client's sync on the old one. The slots move to ProtoSlots, a pure module with native tests, and loop() takes a slot's wants only for the client it read (takeWants). - Deleting a group sends its shades, whose inGroup changed. Deleting a shade unlinks it from its groups and sends them, so a new shade given its id doesn't join them. - next and sync with an id get an ok reply, and a message in pieces gets one bad request, not one per piece. - Feeds check for loop() before they write the event buffer, and log an event too large, as events do. - editChanges() (ModelEditor, native tests) says what clients get after an edit; the edit result carries the shade a group gained or lost. order() takes a sort_list_t. - The frame writers move to ProtoFrame. Renames: pf to proto_field_t, the X-macro letters to TYPE/FIELD/ERR/FEED, proto_request_t to proto_message_t, REQ_* to WANTS_*, fmt to eventJson. The event bodies share sendItem(), the connection type name lives in ESPNetwork, and the loop() task check in SocketEmitter. - e2e: the heap floor check skips when the low since boot is already under it; tests for replies to next and sync and a long message. - SECURITY_PLAN.md splits step 1 into 1a-1d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
d869bb53d5
commit
dc2f1478b6
29 changed files with 1087 additions and 670 deletions
|
|
@ -1,5 +1,44 @@
|
|||
#include "ModelEditor.h"
|
||||
|
||||
edit_changes_t editChanges(model_edit_type_t type, const edit_result_t &result) {
|
||||
edit_changes_t c;
|
||||
switch(type) {
|
||||
case model_edit_type_t::add_shade:
|
||||
case model_edit_type_t::save_shade:
|
||||
case model_edit_type_t::set_paired:
|
||||
case model_edit_type_t::link_remote:
|
||||
case model_edit_type_t::unlink_remote:
|
||||
c.shadeId = result.id;
|
||||
break;
|
||||
case model_edit_type_t::add_group:
|
||||
case model_edit_type_t::save_group:
|
||||
c.groupId = result.id;
|
||||
break;
|
||||
// The shade's inGroup goes with it.
|
||||
case model_edit_type_t::link_to_group:
|
||||
case model_edit_type_t::unlink_from_group:
|
||||
c.groupId = result.id;
|
||||
c.shadeId = result.shadeId;
|
||||
break;
|
||||
case model_edit_type_t::add_room:
|
||||
case model_edit_type_t::save_room:
|
||||
c.roomId = result.id;
|
||||
break;
|
||||
case model_edit_type_t::room_order: c.order = sort_list_t::rooms; break;
|
||||
case model_edit_type_t::shade_order: c.order = sort_list_t::shades; break;
|
||||
case model_edit_type_t::group_order: c.order = sort_list_t::groups; break;
|
||||
case model_edit_type_t::link_repeater:
|
||||
case model_edit_type_t::unlink_repeater:
|
||||
c.repeaters = true;
|
||||
break;
|
||||
case model_edit_type_t::delete_room:
|
||||
case model_edit_type_t::delete_shade:
|
||||
case model_edit_type_t::delete_group:
|
||||
break;
|
||||
}
|
||||
return c;
|
||||
}
|
||||
|
||||
uint8_t firstFreeId(const uint8_t *usedIds, size_t count, uint8_t lastId) {
|
||||
for(uint16_t id = 1; id <= lastId; id++) {
|
||||
bool used = false;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue