fix: edit ops review findings

From the review of 7723711:
- The assembler is locked: a client closed for a full queue is closed
  by the task that was sending, loop(), whose disconnect dropped the
  buffer while async_tcp could be copying into it. A whole message is
  taken out of it, so a disconnect can't free it while it is read.
- loop() expires a message stalled for 10 s, freeing its buffer and
  telling its client, instead of holding it until another client came.
  A binary message is refused before it can touch another's buffer.
- Each edit takes only the fields its route reads; one it would ignore
  is refused by name. linkRemote's rolling code goes in under the
  route's name, so applyModelEdit is unchanged again.
- An edit refused for an id that doesn't exist replies not found
  (edit_result_t::missing). A reply that doesn't fit its buffer goes
  as an internal error, so the op still gets one.
- The TYPE table says what becomes of each op (proto_op_t), which the
  socket switches on. The reply address is one proto_reply_to_t. The
  routes and the ops start and queue an edit the same way
  (newModelEdit, submitModelEdit). The full-list texts and the offered
  remote address rule live in ModelEditor.
- e2e: the sort order test skips a list that it would renumber.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
cjkas 2026-10-24 18:10:06 +02:00
parent 77237111ea
commit 8fa087aa89
23 changed files with 486 additions and 257 deletions

View file

@ -5,13 +5,13 @@
#define PROTO_FIELD_ROW(name, key, kind, def) {#name, key, kind, def},
static const proto_field_info_t FIELDS[] = { PROTO_FIELDS(PROTO_FIELD_ROW) };
#undef PROTO_FIELD_ROW
// Errors and feeds have no sender, so it is left empty and starts as 0.
#define PROTO_NAMED_ROW(name, number, ...) {number, #name, PROTO_SENDER(__VA_ARGS__, 0)},
#define PROTO_SENDER(sender, ...) sender
static const proto_named_t TYPES[] = { PROTO_TYPES(PROTO_NAMED_ROW) };
#define PROTO_TYPE_ROW(name, number, sender, op) {number, #name, sender, op},
static const proto_named_t TYPES[] = { PROTO_TYPES(PROTO_TYPE_ROW) };
#undef PROTO_TYPE_ROW
// Errors and feeds have no sender or op.
#define PROTO_NAMED_ROW(name, number) {number, #name, 0, 0},
static const proto_named_t ERRORS[] = { PROTO_ERRORS(PROTO_NAMED_ROW) };
static const proto_named_t FEEDS[] = { PROTO_FEEDS(PROTO_NAMED_ROW) };
#undef PROTO_SENDER
#undef PROTO_NAMED_ROW
static_assert(sizeof(FIELDS) / sizeof(FIELDS[0]) == static_cast<size_t>(proto_field_t::count), "a field without a row");
@ -21,6 +21,12 @@ const proto_field_info_t *protoFieldByKey(const char *key) {
if(strcmp(f.key, key) == 0) return &f;
return nullptr;
}
bool protoFieldOfKey(const char *key, proto_field_t &out) {
const proto_field_info_t *f = protoFieldByKey(key);
if(!f) return false;
out = static_cast<proto_field_t>(f - FIELDS);
return true;
}
uint8_t protoTypeCount() { return sizeof(TYPES) / sizeof(TYPES[0]); }
const proto_named_t &protoTypeAt(uint8_t index) { return TYPES[index]; }
uint8_t protoErrorCount() { return sizeof(ERRORS) / sizeof(ERRORS[0]); }
@ -32,6 +38,11 @@ const char *protoTypeName(uint8_t number) {
if(t.number == number) return t.name;
return nullptr;
}
proto_op_t protoOpKind(uint8_t type) {
for(const proto_named_t &t : TYPES)
if(t.number == type) return static_cast<proto_op_t>(t.op);
return proto_op_t::none;
}
bool protoClientMaySend(uint8_t type) {
for(const proto_named_t &t : TYPES)
if(t.number == type) return t.sender == 'c' || t.sender == 'b';