aaribaud/ESPSomfy-RTS
0
0
Fork 0
mirror of https://github.com/rstrouse/ESPSomfy-RTS.git synced 2026-10-31 13:52:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

feat: sign tokens with a secret key, compare them in constant time

Browse source 
Tokens were HMAC(serverId, credentials + client IP). serverId is public
(mDNS, MQTT, /loginContext), so anyone who saw a token could test PIN
guesses offline. The key is now 32 random bytes made on first boot in
their own NVS namespace, which no settings save clears and no backup
holds. It is made before WiFi starts, from the bootloader's entropy
source.

Tokens are compared with tokenMatches, which takes the same time
whatever the guess, on the apikey header, the socket upgrade and
/login.

createAPIToken never freed its mbedtls context, so every token it made
leaked: 563 bytes per login on the device, until it ran out of memory
after about 150 logins. It now frees it: 0 bytes over 500 logins.

Every token made before the upgrade is refused once. The web UI asks
for login again, and Home Assistant 3.0 logs in again by itself.

Closes #80

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
cjkas 2026-10-27 19:41:43 +01:00
parent ff7517e10f
commit 43191ba312
8 changed files with 144 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/outputs/ProtoSocket.cpp
View file

@ -23,6 +23,7 @@
#include "Utils.h"
#include "SocketEmitter.h"
#include "../entryPoints/Web.h"
#include "ApiToken.h"
#if HAS_ETHERNET
#include <ETH.h>
#endif
@ -264,7 +265,7 @@ static bool authorized(AsyncWebServerRequest *request) {
if(!key || !request->client()) return false;
char token[65];
webServer.createAPIToken(request->client()->remoteIP(), token);
return key->value() == token;
return tokenMatches(token, key->value().c_str());
}
static void onConnect(AsyncWebSocketClient *client, AsyncWebServerRequest *request) {
const uint32_t id = client->id();