aaribaud/ESPSomfy-RTS
0
0
Fork 0
mirror of https://github.com/rstrouse/ESPSomfy-RTS.git synced 2026-10-31 22:02:17 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix: default a set-favorite request's tilt to the favorite tilt

Browse source 
/setMyPosition filled in a missing tilt with the lift favorite, so a
request without a tilt set the favorite tilt to the lift's. It also took
the stored position as a display one, which flipped it twice on a shade
with flipPosition. requestedFavoriteTilt() now gives the favorite tilt as
displayed. Home Assistant never calls /setMyPosition and the web UI always
sends a tilt, so only other API callers see the change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
cjkas 2026-10-14 15:57:49 +02:00
parent 377a1217a6
commit 1128431e8c
5 changed files with 34 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/test_motion/test_motion.cpp
View file

@ -285,6 +285,25 @@ static void test_stepTargets_without_a_travel_time_or_step_size_is_ignored() {
ASSERT_ACTION(StepAction::ignore, stepOf(tilt_types::none, DOWN, 100, 0, 1, 20000, 10000, 5000, 0).action);
}
/*********************************************************************
* requestedFavoriteTilt
********************************************************************/
static void test_favorite_tilt_keeps_the_requested_tilt() {
TEST_ASSERT_EQUAL_INT8(25, requestedFavoriteTilt(25, tilt_types::integrated, 70.0f, false));
}
static void test_favorite_tilt_defaults_to_the_favorite_tilt() {
// Not the lift favorite: that was the old default.
TEST_ASSERT_EQUAL_INT8(70, requestedFavoriteTilt(-1, tilt_types::tiltmotor, 70.0f, false));
// The request is in display positions, so a flipped shade gets its favorite flipped.
TEST_ASSERT_EQUAL_INT8(30, requestedFavoriteTilt(-1, tilt_types::tiltmotor, 70.0f, true));
}
static void test_favorite_tilt_without_a_favorite_is_unset() {
TEST_ASSERT_EQUAL_INT8(-1, requestedFavoriteTilt(-1, tilt_types::integrated, -1.0f, false));
}
static void test_favorite_tilt_of_a_shade_without_tilt_is_unset() {
TEST_ASSERT_EQUAL_INT8(-1, requestedFavoriteTilt(25, tilt_types::none, 70.0f, false));
}
int main(int argc, char **argv) {
(void)argc;
(void)argv;
@ -312,6 +331,10 @@ int main(int argc, char **argv) {
RUN_TEST(test_stepTargets_integrated_at_both_ends_is_ignored);
RUN_TEST(test_stepTargets_without_a_travel_time_or_step_size_is_ignored);
RUN_TEST(test_displayPosition);
RUN_TEST(test_favorite_tilt_keeps_the_requested_tilt);
RUN_TEST(test_favorite_tilt_defaults_to_the_favorite_tilt);
RUN_TEST(test_favorite_tilt_without_a_favorite_is_unset);
RUN_TEST(test_favorite_tilt_of_a_shade_without_tilt_is_unset);
RUN_TEST(test_flipCommand_swaps_directions);
RUN_TEST(test_flipCommand_keeps_the_rest);
RUN_TEST(test_txhold_idle_shade_is_held);